]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
b43legacy: Do not return TX_BUSY from op_tx
authorMichael Buesch <mb@bu3sch.de>
Wed, 2 Jul 2008 23:06:32 +0000 (01:06 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 24 Jul 2008 16:14:01 +0000 (09:14 -0700)
Never return TX_BUSY from op_tx. It doesn't make sense to return
TX_BUSY, if we can not transmit the packet.
Drop the packet and return TX_OK.

Upstream commit is
eb803e419ca6be06ece2e42027bb4ebd8ec09f91

Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/net/wireless/b43legacy/main.c

index 0f7a6e7bd96a74fad4172f547bfbe7dc75a0bfe7..531aeb22230f1c0b8b450e41522a2465a106a548 100644 (file)
@@ -2350,8 +2350,10 @@ static int b43legacy_op_tx(struct ieee80211_hw *hw,
        } else
                err = b43legacy_dma_tx(dev, skb, ctl);
 out:
-       if (unlikely(err))
-               return NETDEV_TX_BUSY;
+       if (unlikely(err)) {
+               /* Drop the packet. */
+               dev_kfree_skb_any(skb);
+       }
        return NETDEV_TX_OK;
 }