]> git.karo-electronics.de Git - linux-beck.git/commitdiff
regulator: twl-regulator: rework fixed regulator definition
authorNicolae Rosia <Nicolae_Rosia@mentor.com>
Sat, 12 Nov 2016 12:42:14 +0000 (14:42 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 16 Nov 2016 18:03:39 +0000 (18:03 +0000)
TWL603X and TWL4030 are different and have different code logic.
Rework the regulator definition method so we can split the file
easily in twl4030 and twl6030.

Signed-off-by: Nicolae Rosia <Nicolae_Rosia@mentor.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/twl-regulator.c

index 210681d6b7438b71dc2a0d508d24708ac2dd2e36..23f7b31f6355150259630ed6955ecea2239b6a48 100644 (file)
@@ -898,15 +898,6 @@ static struct regulator_ops twlsmps_ops = {
 
 /*----------------------------------------------------------------------*/
 
-#define TWL4030_FIXED_LDO(label, offset, mVolts, num, turnon_delay, \
-                       remap_conf) \
-               TWL_FIXED_LDO(label, offset, mVolts, num, turnon_delay, \
-                       remap_conf, TWL4030, twl4030fixed_ops, \
-                       twl4030reg_map_mode)
-#define TWL6030_FIXED_LDO(label, offset, mVolts, turnon_delay) \
-               TWL_FIXED_LDO(label, offset, mVolts, 0x0, turnon_delay, \
-                       0x0, TWL6030, twl6030fixed_ops, NULL)
-
 #define TWL4030_ADJUSTABLE_LDO(label, offset, num, turnon_delay, remap_conf) \
 static const struct twlreg_info TWL4030_INFO_##label = { \
        .base = offset, \
@@ -983,8 +974,27 @@ static const struct twlreg_info TWL6032_INFO_##label = { \
                }, \
        }
 
-#define TWL_FIXED_LDO(label, offset, mVolts, num, turnon_delay, remap_conf, \
-               family, operations, map_mode) \
+#define TWL6030_FIXED_LDO(label, offset, mVolts, turnon_delay) \
+static const struct twlreg_info TWLFIXED_INFO_##label = { \
+       .base = offset, \
+       .id = 0, \
+       .min_mV = mVolts, \
+       .remap = 0, \
+       .desc = { \
+               .name = #label, \
+               .id = TWL6030##_REG_##label, \
+               .n_voltages = 1, \
+               .ops = &twl6030fixed_ops, \
+               .type = REGULATOR_VOLTAGE, \
+               .owner = THIS_MODULE, \
+               .min_uV = mVolts * 1000, \
+               .enable_time = turnon_delay, \
+               .of_map_mode = NULL, \
+               }, \
+       }
+
+#define TWL4030_FIXED_LDO(label, offset, mVolts, num, turnon_delay, \
+                       remap_conf) \
 static const struct twlreg_info TWLFIXED_INFO_##label = { \
        .base = offset, \
        .id = num, \
@@ -992,14 +1002,14 @@ static const struct twlreg_info TWLFIXED_INFO_##label = { \
        .remap = remap_conf, \
        .desc = { \
                .name = #label, \
-               .id = family##_REG_##label, \
+               .id = TWL4030##_REG_##label, \
                .n_voltages = 1, \
-               .ops = &operations, \
+               .ops = &twl4030fixed_ops, \
                .type = REGULATOR_VOLTAGE, \
                .owner = THIS_MODULE, \
                .min_uV = mVolts * 1000, \
                .enable_time = turnon_delay, \
-               .of_map_mode = map_mode, \
+               .of_map_mode = twl4030reg_map_mode, \
                }, \
        }