]> git.karo-electronics.de Git - linux-beck.git/commitdiff
KVM: s390: document FLIC behavior on unsupported
authorHalil Pasic <pasic@linux.vnet.ibm.com>
Thu, 25 Feb 2016 12:26:32 +0000 (13:26 +0100)
committerCornelia Huck <cornelia.huck@de.ibm.com>
Wed, 20 Apr 2016 12:27:32 +0000 (14:27 +0200)
FLIC behavior deviates from the API documentation in reporting EINVAL
instead of ENXIO for KVM_SET_DEVICE_ATTR/KVM_GET_DEVICE_ATTR when the group
or attribute is unknown/unsupported. Unfortunately this can not be fixed
for historical reasons. Let us at least have it documented.

Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Documentation/virtual/kvm/devices/s390_flic.txt

index e3e314cb83e83fd08f99fc0f3859727b22eb0cc1..646f47470f9842ad88fad3a87e100ba9632c1475 100644 (file)
@@ -94,3 +94,9 @@ struct kvm_s390_io_adapter_req {
     KVM_S390_IO_ADAPTER_UNMAP
       release a userspace page for the translated address specified in addr
       from the list of mappings
+
+Note: The KVM_SET_DEVICE_ATTR/KVM_GET_DEVICE_ATTR device ioctls executed on
+FLIC with an unknown group or attribute gives the error code EINVAL (instead of
+ENXIO, as specified in the API documentation). It is not possible to conclude
+that a FLIC operation is unavailable based on the error code resulting from a
+usage attempt.