]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
spi/rockchip: fix error return code in rockchip_spi_probe()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Sun, 20 Jul 2014 14:02:04 +0000 (22:02 +0800)
committerMark Brown <broonie@linaro.org>
Fri, 25 Jul 2014 17:25:59 +0000 (18:25 +0100)
Fix to return -EINVAL from the error handling case instead of 0 when
failed to get fifo length.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Mark Brown <broonie@linaro.org>
drivers/spi/spi-rockchip.c

index 47c9168f18b235badd25304896a9a642989a235d..c0743604b906c749b62d1fedaaa8f3250b70c0c9 100644 (file)
@@ -640,6 +640,7 @@ static int rockchip_spi_probe(struct platform_device *pdev)
        rs->fifo_len = get_fifo_len(rs);
        if (!rs->fifo_len) {
                dev_err(&pdev->dev, "Failed to get fifo length\n");
+               ret = -EINVAL;
                goto err_get_fifo_len;
        }