]> git.karo-electronics.de Git - linux-beck.git/commitdiff
thermal: rockchip: fixes the conversion table
authorCaesar Wang <wxt@rock-chips.com>
Thu, 5 Jan 2017 04:37:55 +0000 (12:37 +0800)
committerEduardo Valentin <edubezval@gmail.com>
Tue, 17 Jan 2017 04:30:49 +0000 (20:30 -0800)
As Ayaka reported the thermal was abormal on rk3288 at booting time.
thermal thermal_zone1: critical temperature reached(125 C),shutting down
thermal thermal_zone2: critical temperature reached(125 C),shutting down
thermal thermal_zone1: critical temperature reached(125 C),shutting down
thermal thermal_zone2: critical temperature reached(125 C),shutting down
...
The root caused by reading the invald analogic value, the value is zero
will convert the 125 degree to trigger the critical temperature.
Fixes it with insteading of the incorrect reading now.

Fixes commit cadf29dc2a8bcaae83
("thermal: rockchip: optimize the conversion table")

Reported-by: ayaka <ayaka@soulik.info>
Signed-off-by: Caesar Wang <wxt@rock-chips.com>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
drivers/thermal/rockchip_thermal.c

index cbbf0ce2302c1b9825f1b99e1bd59e0ae16ca6ed..4c779651245351ea488cf20dec87199d755eb135 100644 (file)
@@ -464,7 +464,7 @@ static int rk_tsadcv2_code_to_temp(const struct chip_tsadc_table *table,
        switch (table->mode) {
        case ADC_DECREMENT:
                code &= table->data_mask;
-               if (code < table->id[high].code)
+               if (code <= table->id[high].code)
                        return -EAGAIN;         /* Incorrect reading */
 
                while (low <= high) {