]> git.karo-electronics.de Git - linux-beck.git/commitdiff
staging: unisys: visornic - prevent NETDEV WATCHDOG timeouts after IO recovery
authorTim Sell <Timothy.Sell@unisys.com>
Fri, 24 Jul 2015 16:00:25 +0000 (12:00 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 24 Jul 2015 20:43:37 +0000 (13:43 -0700)
After IO partition recovery, it was possible to get into a situation where
a visornic device would repeatedly report:

    NETDEV WATCHDOG: eth0 (): transmit queue 0 timed out

The actual problem would affect any visornic device that was rapidly
transmitting at the same time the IO partition was being recovered. Once
you hit the problem, the only way to resume use of the nic would be to
reboot the Linux client partition.

The problem was caused by chstat.sent_xmit and chstat.got_xmit_done NOT
getting cleared during IO partition recovery. This is necessary because
outstanding xmits would essentially be "abandoned" during such recovery.
These fields are now cleared in virtnic_serverdown_complete().

Signed-off-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visornic/visornic_main.c

index a4aa8afd04dd57a05116ff6475fa298f302b677e..2a9b055dcc51abd40477fd2e04ed476b3a471b0b 100644 (file)
@@ -380,6 +380,8 @@ visornic_serverdown_complete(struct visornic_devdata *devdata)
        rtnl_unlock();
 
        atomic_set(&devdata->num_rcvbuf_in_iovm, 0);
+       devdata->chstat.sent_xmit = 0;
+       devdata->chstat.got_xmit_done = 0;
 
        if (devdata->server_down_complete_func)
                (*devdata->server_down_complete_func)(devdata->dev, 0);