]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
selftests-ipc-message-queue-copy-feature-test-checkpatch-fixes
authorAndrew Morton <akpm@linux-foundation.org>
Thu, 25 Oct 2012 01:15:19 +0000 (12:15 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Wed, 31 Oct 2012 05:50:01 +0000 (16:50 +1100)
WARNING: line over 80 characters
#114: FILE: tools/testing/selftests/ipc/msgque.c:61:
+ if (msgsnd(msgque->msq_id, &msgque->messages[i].mtype, msgque->messages[i].msize, IPC_NOWAIT) != 0) {

WARNING: line over 80 characters
#128: FILE: tools/testing/selftests/ipc/msgque.c:75:
+ ret = msgrcv(msgque->msq_id, &message.mtype, MAX_MSG_SIZE, 0, IPC_NOWAIT);

WARNING: line over 80 characters
#137: FILE: tools/testing/selftests/ipc/msgque.c:84:
+ printf("Wrong message size: %d (expected %d)\n", ret, msgque->messages[cnt].msize);

WARNING: line over 80 characters
#179: FILE: tools/testing/selftests/ipc/msgque.c:126:
+ printf("Failed to get stats for IPC queue with id %d\n", msgque->kern_id);

WARNING: line over 80 characters
#198: FILE: tools/testing/selftests/ipc/msgque.c:145:
+ ret = msgrcv(msgque->msq_id, &msgque->messages[i].mtype, MAX_MSG_SIZE, i, IPC_NOWAIT | MSG_COPY);

WARNING: line over 80 characters
#214: FILE: tools/testing/selftests/ipc/msgque.c:161:
+ if (msgsnd(msgque->msq_id, &msgbuf.mtype, sizeof(TEST_STRING), IPC_NOWAIT) != 0) {

WARNING: line over 80 characters
#221: FILE: tools/testing/selftests/ipc/msgque.c:168:
+ if (msgsnd(msgque->msq_id, &msgbuf.mtype, sizeof(ANOTHER_TEST_STRING), IPC_NOWAIT) != 0) {

WARNING: space prohibited between function name and open parenthesis '('
#228: FILE: tools/testing/selftests/ipc/msgque.c:175:
+int main (int argc, char **argv)

total: 0 errors, 8 warnings, 256 lines checked

./patches/selftests-ipc-message-queue-copy-feature-test.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Stanislav Kinsbursky <skinsbursky@parallels.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
tools/testing/selftests/ipc/msgque.c

index e2d6a64c3a6f3e8da7bbf07191c281d5c56b7915..69a2ce012c0db6cac6add816495560af32e55763 100644 (file)
@@ -172,7 +172,7 @@ int fill_msgque(struct msgque_data *msgque)
        return 0;
 }
 
-int main (int argc, char **argv)
+int main(int argc, char **argv)
 {
        key_t key;
        int msg, pid, err;