]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
SUNRPC: Use KERN_DEFAULT for debugging printk's
authorChuck Lever <chuck.lever@oracle.com>
Wed, 15 Feb 2012 21:35:08 +0000 (16:35 -0500)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Thu, 16 Feb 2012 19:55:30 +0000 (14:55 -0500)
Our dprintk() debugging facility doesn't specify any verbosity level
for it's printk() calls, but it should.

The default verbosity for printk's is KERN_DEFAULT.  You might argue
that these are debugging printk's and thus the verbosity should be
KERN_DEBUG.  That would mean that to see NFS and SUNRPC debugging
output an admin would also have to boost the syslog verbosity, which
would be insufferably noisy.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
include/linux/sunrpc/debug.h

index 2a11eb278f640a688438c88a92498965a51cc3be..b506936f4ce68e1d29e4cab487152d751b06a65b 100644 (file)
@@ -54,7 +54,11 @@ extern unsigned int          nlm_debug;
 #undef ifdebug
 #ifdef RPC_DEBUG                       
 # define ifdebug(fac)          if (unlikely(rpc_debug & RPCDBG_##fac))
-# define dfprintk(fac, args...)        do { ifdebug(fac) printk(args); } while(0)
+# define dfprintk(fac, args...)        \
+       do { \
+               ifdebug(fac) \
+                       printk(KERN_DEFAULT args); \
+       } while (0)
 # define RPC_IFDEBUG(x)                x
 #else
 # define ifdebug(fac)          if (0)