]> git.karo-electronics.de Git - linux-beck.git/commitdiff
[media] s5p-jpeg: Remove unneeded struct vb2_queue clear on queue_init()
authorEzequiel García <elezegarcia@gmail.com>
Thu, 23 Aug 2012 12:08:30 +0000 (09:08 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sat, 15 Sep 2012 14:48:23 +0000 (11:48 -0300)
queue_init() is always called by v4l2_m2m_ctx_init(), which allocates
a context struct v4l2_m2m_ctx with kzalloc.
Therefore, there is no need to clear vb2_queue src/dst structs.

Cc: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/platform/s5p-jpeg/jpeg-core.c

index 72c3e525f921ed6daad56aa106327d21432d2a5b..90459cefb2b84003a66da14d86f0d7a2fbbca102 100644 (file)
@@ -1223,7 +1223,6 @@ static int queue_init(void *priv, struct vb2_queue *src_vq,
        struct s5p_jpeg_ctx *ctx = priv;
        int ret;
 
-       memset(src_vq, 0, sizeof(*src_vq));
        src_vq->type = V4L2_BUF_TYPE_VIDEO_OUTPUT;
        src_vq->io_modes = VB2_MMAP | VB2_USERPTR;
        src_vq->drv_priv = ctx;
@@ -1235,7 +1234,6 @@ static int queue_init(void *priv, struct vb2_queue *src_vq,
        if (ret)
                return ret;
 
-       memset(dst_vq, 0, sizeof(*dst_vq));
        dst_vq->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
        dst_vq->io_modes = VB2_MMAP | VB2_USERPTR;
        dst_vq->drv_priv = ctx;