]> git.karo-electronics.de Git - linux-beck.git/commitdiff
drm/bochs: Remove unnecessary NULL check in bo_unref
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Sat, 5 Apr 2014 08:43:37 +0000 (10:43 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 22 Apr 2014 13:39:39 +0000 (15:39 +0200)
ttm_bo_unref unconditionally calls kref_put on it's argument, so the
thing can't be NULL without already causing Oopses.

Spotted by coverity.

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/bochs/bochs_mm.c

index f488be55d650e332560e7bd83212007cac50c4a5..4a239e931affb6bcf32d2ab41d630005eaddd75e 100644 (file)
@@ -434,9 +434,7 @@ static void bochs_bo_unref(struct bochs_bo **bo)
 
        tbo = &((*bo)->bo);
        ttm_bo_unref(&tbo);
-       if (tbo == NULL)
-               *bo = NULL;
-
+       *bo = NULL;
 }
 
 void bochs_gem_free_object(struct drm_gem_object *obj)