]> git.karo-electronics.de Git - linux-beck.git/commitdiff
imx-drm: imx-drm-core: delete unneeded test before of_node_put
authorJulia Lawall <Julia.Lawall@lip6.fr>
Fri, 8 Aug 2014 10:07:50 +0000 (12:07 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 16 Aug 2014 19:23:12 +0000 (12:23 -0700)
Of_node_put supports NULL as its argument, so the initial test is not
necessary.

Suggested by Uwe Kleine-König.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e;
@@

-if (e)
   of_node_put(e);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/imx-drm/imx-drm-core.c

index 6b22106534d8d62451e18f5fe453bd3c2bc2078f..1852300412b47b1ee73dc21d494da8db917d3b91 100644 (file)
@@ -471,8 +471,7 @@ int imx_drm_encoder_parse_of(struct drm_device *drm,
                crtc_mask |= mask;
        }
 
-       if (ep)
-               of_node_put(ep);
+       of_node_put(ep);
        if (i == 0)
                return -ENOENT;