]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
drm/bochs: Remove unecessary NULL check in gem_free
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Sat, 5 Apr 2014 08:44:51 +0000 (10:44 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 22 Apr 2014 13:39:40 +0000 (15:39 +0200)
The ->gem_free_object never gets called with a NULL pointer, the check
is redundant. Also checking after the upcast allows compilers to elide
it anyway.

Noticed while chasing coverity reports, somehow this one here was not
flagged.

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/bochs/bochs_mm.c

index 4a239e931affb6bcf32d2ab41d630005eaddd75e..b9a695d92792ee224868d3f9f9ce32e0475d48c8 100644 (file)
@@ -441,8 +441,6 @@ void bochs_gem_free_object(struct drm_gem_object *obj)
 {
        struct bochs_bo *bochs_bo = gem_to_bochs_bo(obj);
 
-       if (!bochs_bo)
-               return;
        bochs_bo_unref(&bochs_bo);
 }