]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
usb: gadget: r8a66597-udc: use devm_ioremap_resource() for registers
authorBen Dooks <ben.dooks@codethink.co.uk>
Tue, 17 Jun 2014 15:14:54 +0000 (16:14 +0100)
committerFelipe Balbi <balbi@ti.com>
Mon, 30 Jun 2014 17:22:51 +0000 (12:22 -0500)
trivial patch removing boilerplate clode.

Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/r8a66597-udc.c

index b698a490cc7d78e345a4a518af3c39238c8cb5af..4e86ec5cbecf6288d406bf931e88dd37252e37ba 100644 (file)
@@ -1826,7 +1826,6 @@ static int __exit r8a66597_remove(struct platform_device *pdev)
 
        usb_del_gadget_udc(&r8a66597->gadget);
        del_timer_sync(&r8a66597->timer);
-       iounmap(r8a66597->reg);
        if (r8a66597->pdata->sudmac)
                iounmap(r8a66597->sudmac_reg);
        free_irq(platform_get_irq(pdev, 0), r8a66597);
@@ -1877,11 +1876,9 @@ static int __init r8a66597_probe(struct platform_device *pdev)
        unsigned long irq_trigger;
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (!res) {
-               ret = -ENODEV;
-               dev_err(&pdev->dev, "platform_get_resource error.\n");
-               goto clean_up;
-       }
+       reg = devm_ioremap_resource(&pdev->dev, res);
+       if (!reg)
+               return -ENODEV;
 
        ires = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
        irq = ires->start;
@@ -1893,13 +1890,6 @@ static int __init r8a66597_probe(struct platform_device *pdev)
                goto clean_up;
        }
 
-       reg = ioremap(res->start, resource_size(res));
-       if (reg == NULL) {
-               ret = -ENOMEM;
-               dev_err(&pdev->dev, "ioremap error.\n");
-               goto clean_up;
-       }
-
        /* initialize ucd */
        r8a66597 = kzalloc(sizeof(struct r8a66597), GFP_KERNEL);
        if (r8a66597 == NULL) {
@@ -2007,8 +1997,6 @@ clean_up:
                                                r8a66597->ep0_req);
                kfree(r8a66597);
        }
-       if (reg)
-               iounmap(reg);
 
        return ret;
 }