]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
staging: comedi: dyna_pci10xx: usleep_range is preferred over udelay
authorSaber Rezvani <irsaber@gmail.com>
Fri, 10 Feb 2017 18:11:11 +0000 (21:41 +0330)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Feb 2017 17:08:30 +0000 (09:08 -0800)
Fix the checkpatch.pl issue:
CHECK: usleep_range is preferred over udelay

Signed-off-by: Saber Rezvani <irsaber@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/dyna_pci10xx.c

index c9eb26fab44e7d02951287d9d48f3d3f74e0f5d5..bab7ac9e62370cd2da331f7f4826696bd316fe37 100644 (file)
@@ -89,7 +89,7 @@ static int dyna_pci10xx_insn_read_ai(struct comedi_device *dev,
                /* trigger conversion */
                smp_mb();
                outw_p(0x0000 + range + chan, dev->iobase + 2);
-               udelay(10);
+               usleep_range(10, 20);
 
                ret = comedi_timeout(dev, s, insn, dyna_pci10xx_ai_eoc, 0);
                if (ret)
@@ -125,7 +125,7 @@ static int dyna_pci10xx_insn_write_ao(struct comedi_device *dev,
                smp_mb();
                /* trigger conversion and write data */
                outw_p(data[n], dev->iobase);
-               udelay(10);
+               usleep_range(10, 20);
        }
        mutex_unlock(&devpriv->mutex);
        return n;
@@ -143,7 +143,7 @@ static int dyna_pci10xx_di_insn_bits(struct comedi_device *dev,
        mutex_lock(&devpriv->mutex);
        smp_mb();
        d = inw_p(devpriv->BADR3);
-       udelay(10);
+       usleep_range(10, 100);
 
        /* on return the data[0] contains output and data[1] contains input */
        data[1] = d;
@@ -163,7 +163,7 @@ static int dyna_pci10xx_do_insn_bits(struct comedi_device *dev,
        if (comedi_dio_update_state(s, data)) {
                smp_mb();
                outw_p(s->state, devpriv->BADR3);
-               udelay(10);
+               usleep_range(10, 100);
        }
 
        data[1] = s->state;