]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
xfs: remote attribute lookups require the value length
authorDave Chinner <dchinner@redhat.com>
Sun, 19 May 2013 23:51:16 +0000 (09:51 +1000)
committerBen Myers <bpm@sgi.com>
Mon, 20 May 2013 22:16:12 +0000 (17:16 -0500)
When reading a remote attribute, to correctly calculate the length
of the data buffer for CRC enable filesystems, we need to know the
length of the attribute data. We get this information when we look
up the attribute, but we don't store it in the args structure along
with the other remote attr information we get from the lookup. Add
this information to the args structure so we can use it
appropriately.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Ben Myers <bpm@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
fs/xfs/xfs_attr_leaf.c

index 8eeb88fb3201a516a9394e2d8621168d9c62948c..0bce1b3485800a9319fb1116a5d8d11edf485392 100644 (file)
@@ -2332,9 +2332,10 @@ xfs_attr3_leaf_lookup_int(
                        if (!xfs_attr_namesp_match(args->flags, entry->flags))
                                continue;
                        args->index = probe;
+                       args->valuelen = be32_to_cpu(name_rmt->valuelen);
                        args->rmtblkno = be32_to_cpu(name_rmt->valueblk);
                        args->rmtblkcnt = XFS_B_TO_FSB(args->dp->i_mount,
-                                                  be32_to_cpu(name_rmt->valuelen));
+                                                      args->valuelen);
                        return XFS_ERROR(EEXIST);
                }
        }