]> git.karo-electronics.de Git - linux-beck.git/commitdiff
rtlwifi: Use dev_kfree_skb_irq instead of kfree_skb
authorWei Yongjun <weiyongjun1@huawei.com>
Tue, 1 Nov 2016 14:48:40 +0000 (14:48 +0000)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 17 Nov 2016 06:48:33 +0000 (08:48 +0200)
It is not allowed to call kfree_skb() from hardware interrupt
context or with interrupts being disabled, spin_lock_irqsave()
make sure always in irq disable context. So the kfree_skb()
should be replaced with dev_kfree_skb_irq().

This is detected by Coccinelle semantic patch.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/realtek/rtlwifi/core.c

index f95760c13c56eeee19229c375cc54be371f461bf..a11e8f5c3799ef142705d7d2b328bcc4e7bbb7af 100644 (file)
@@ -1832,7 +1832,7 @@ bool rtl_cmd_send_packet(struct ieee80211_hw *hw, struct sk_buff *skb)
 
        spin_lock_irqsave(&rtlpriv->locks.irq_th_lock, flags);
        pskb = __skb_dequeue(&ring->queue);
-       kfree_skb(pskb);
+       dev_kfree_skb_irq(pskb);
 
        /*this is wrong, fill_tx_cmddesc needs update*/
        pdesc = &ring->desc[0];