]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
hpsa: do not ack controller events on controllers that do not support it
authorStephen Cameron <stephenmcameron@gmail.com>
Fri, 23 Jan 2015 22:44:07 +0000 (16:44 -0600)
committerJames Bottomley <JBottomley@Parallels.com>
Mon, 2 Feb 2015 17:57:42 +0000 (09:57 -0800)
Acking controller events on controllers that do not support
it can cause such controllers to lock up.

Reviewed-by: Scott Teel <scott.teel@pmcs.com>
Signed-off-by: Joe Handzik <joseph.t.handzik@hp.com>
Signed-off-by: Don Brace <don.brace@pmcs.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/scsi/hpsa.c

index 5abd49d8594001b4c5c4b1f74767ffcd73444a96..afd192d2d27dba24d755739de0704f56660b7610 100644 (file)
@@ -6674,6 +6674,9 @@ static void hpsa_ack_ctlr_events(struct ctlr_info *h)
        int i;
        char *event_type;
 
+       if (!(h->fw_support & MISC_FW_EVENT_NOTIFY))
+               return;
+
        /* Ask the controller to clear the events we're handling. */
        if ((h->transMethod & (CFGTBL_Trans_io_accel1
                        | CFGTBL_Trans_io_accel2)) &&