]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
libnvdimm, btt: convert some info messages to warn/err
authorVishal Verma <vishal.l.verma@intel.com>
Sat, 1 Jul 2017 00:32:51 +0000 (18:32 -0600)
committerDan Williams <dan.j.williams@intel.com>
Sat, 1 Jul 2017 15:49:59 +0000 (08:49 -0700)
Some critical messages such as IO errors, metadata failures were printed
with dev_info. Make them louder by upgrading them to dev_warn or
dev_error.

Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/nvdimm/btt.c

index 4e56e720288d9aefa86722bfbfed50d03a8e2f64..2af329d6a833774d287b40b8bf1c411b7c34de50 100644 (file)
@@ -323,7 +323,7 @@ static int btt_log_read(struct arena_info *arena, u32 lane,
 
        old_ent = btt_log_get_old(log);
        if (old_ent < 0 || old_ent > 1) {
-               dev_info(to_dev(arena),
+               dev_err(to_dev(arena),
                                "log corruption (%d): lane %d seq [%d, %d]\n",
                        old_ent, lane, log[0].seq, log[1].seq);
                /* TODO set error state? */
@@ -684,7 +684,7 @@ static int discover_arenas(struct btt *btt)
                                dev_info(to_dev(arena), "No existing arenas\n");
                                goto out;
                        } else {
-                               dev_info(to_dev(arena),
+                               dev_err(to_dev(arena),
                                                "Found corrupted metadata!\n");
                                ret = -ENODEV;
                                goto out;
@@ -1227,7 +1227,7 @@ static blk_qc_t btt_make_request(struct request_queue *q, struct bio *bio)
                err = btt_do_bvec(btt, bip, bvec.bv_page, len, bvec.bv_offset,
                                  op_is_write(bio_op(bio)), iter.bi_sector);
                if (err) {
-                       dev_info(&btt->nd_btt->dev,
+                       dev_err(&btt->nd_btt->dev,
                                        "io error in %s sector %lld, len %d,\n",
                                        (op_is_write(bio_op(bio))) ? "WRITE" :
                                        "READ",
@@ -1373,7 +1373,7 @@ static struct btt *btt_init(struct nd_btt *nd_btt, unsigned long long rawsize,
        }
 
        if (btt->init_state != INIT_READY && nd_region->ro) {
-               dev_info(dev, "%s is read-only, unable to init btt metadata\n",
+               dev_warn(dev, "%s is read-only, unable to init btt metadata\n",
                                dev_name(&nd_region->dev));
                return NULL;
        } else if (btt->init_state != INIT_READY) {