]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
GFS2: Fix ref count bug relating to atomic_open
authorSteven Whitehouse <swhiteho@redhat.com>
Thu, 21 Nov 2013 18:47:57 +0000 (18:47 +0000)
committerSteven Whitehouse <swhiteho@redhat.com>
Thu, 21 Nov 2013 18:47:57 +0000 (18:47 +0000)
In the case that atomic_open calls finish_no_open() with
the dentry that was supplied to gfs2_atomic_open() an
extra reference count is required. This patch fixes that
issue preventing a bug trap triggering at umount time.

Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
fs/gfs2/inode.c

index 1615df16cf4eb9ed5c5c4f20ee46c56bc00d3143..7119504159f17ba8fdde8317abee9eaf38583c71 100644 (file)
@@ -1171,8 +1171,11 @@ static int gfs2_atomic_open(struct inode *dir, struct dentry *dentry,
        if (d != NULL)
                dentry = d;
        if (dentry->d_inode) {
-               if (!(*opened & FILE_OPENED))
+               if (!(*opened & FILE_OPENED)) {
+                       if (d == NULL)
+                               dget(dentry);
                        return finish_no_open(file, dentry);
+               }
                dput(d);
                return 0;
        }