]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
drm/radeon: convert radeon vfct code to use acpi_get_table_with_size
authorAlex Deucher <alexander.deucher@amd.com>
Mon, 20 Aug 2012 15:06:21 +0000 (11:06 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 2 Oct 2012 17:30:23 +0000 (10:30 -0700)
commit 7c3906d04a4587dceaa78cc1ae6b14e6454ee02a upstream.

Allows us to verify the table size.

Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/radeon/radeon_bios.c

index 602898dd1669ee829130e2acb5637e2134801272..d306cc8fdeaa918294cf9576e0ab834d05882e87 100644 (file)
@@ -554,13 +554,12 @@ static bool radeon_acpi_vfct_bios(struct radeon_device *rdev)
 {
        bool ret = false;
        struct acpi_table_header *hdr;
-       /* acpi_get_table_with_size is not exported :( */
-       acpi_size tbl_size = 0x7fffffff;
+       acpi_size tbl_size;
        UEFI_ACPI_VFCT *vfct;
        GOP_VBIOS_CONTENT *vbios;
        VFCT_IMAGE_HEADER *vhdr;
 
-       if (!ACPI_SUCCESS(acpi_get_table("VFCT", 1, &hdr)))
+       if (!ACPI_SUCCESS(acpi_get_table_with_size("VFCT", 1, &hdr, &tbl_size)))
                return false;
        if (tbl_size < sizeof(UEFI_ACPI_VFCT)) {
                DRM_ERROR("ACPI VFCT table present but broken (too short #1)\n");
@@ -597,7 +596,6 @@ static bool radeon_acpi_vfct_bios(struct radeon_device *rdev)
        ret = !!rdev->bios;
 
 out_unmap:
-       /* uh, no idea what to do here... */
        return ret;
 }
 #else