]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
nfs: idr_destroy() no longer needs idr_remove_all()
authorTejun Heo <tj@kernel.org>
Thu, 7 Feb 2013 01:28:02 +0000 (12:28 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Mon, 18 Feb 2013 05:47:26 +0000 (16:47 +1100)
idr_destroy() can destroy idr by itself and idr_remove_all() is being
deprecated.  Drop reference to idr_remove_all().  Note that the code
wasn't completely correct before because idr_remove() on all entries
doesn't necessarily release all idr_layers which could lead to memory
leak.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/nfs/client.c

index 9f3c66438d0e52251182fdf00685488e9b2b9043..84d8eae203a7985ba7a78d54849e8e87782e44f8 100644 (file)
@@ -197,7 +197,6 @@ error_0:
 EXPORT_SYMBOL_GPL(nfs_alloc_client);
 
 #if IS_ENABLED(CONFIG_NFS_V4)
-/* idr_remove_all is not needed as all id's are removed by nfs_put_client */
 void nfs_cleanup_cb_ident_idr(struct net *net)
 {
        struct nfs_net *nn = net_generic(net, nfs_net_id);