]> git.karo-electronics.de Git - linux-beck.git/commitdiff
drm/ast: Remove unnecessary NULL check in bo_unref
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Sat, 5 Apr 2014 08:10:51 +0000 (10:10 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 22 Apr 2014 13:39:08 +0000 (15:39 +0200)
ttm_bo_unref unconditionally calls kref_put on it's argument, so the
thing can't be NULL without already causing Oopses.

Spotted by coverity.

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/ast/ast_main.c

index 50535fd5a88d258492b90ca9e9e9cebfaf2de563..38941a6563123141a8ebded9d54600c2bbe8acf3 100644 (file)
@@ -411,10 +411,9 @@ static void ast_bo_unref(struct ast_bo **bo)
 
        tbo = &((*bo)->bo);
        ttm_bo_unref(&tbo);
-       if (tbo == NULL)
-               *bo = NULL;
-
+       *bo = NULL;
 }
+
 void ast_gem_free_object(struct drm_gem_object *obj)
 {
        struct ast_bo *ast_bo = gem_to_ast_bo(obj);