]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
regulator: max77686: Consistently index opmode array by rdev id
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>
Tue, 4 Nov 2014 08:49:41 +0000 (09:49 +0100)
committerMark Brown <broonie@kernel.org>
Tue, 4 Nov 2014 20:41:28 +0000 (20:41 +0000)
Mixed indexes were used for array of opmodes in max77686_data structure:
id of regulator and index of regulator_desc array.

These indexes are exactly the same but the mixture may confuse. Use
consistently the id of regulator.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/max77686.c

index 09b0d8c20a9d0b6980a60f26df02c92c5cb397b4..27c5f455604479cba24fbfcfc9ebae9adff1912c 100644 (file)
@@ -82,6 +82,7 @@ enum max77686_ramp_rate {
 };
 
 struct max77686_data {
+       /* Array indexed by regulator id */
        unsigned int opmode[MAX77686_REGULATORS];
 };
 
@@ -513,12 +514,13 @@ static int max77686_pmic_probe(struct platform_device *pdev)
 
        for (i = 0; i < MAX77686_REGULATORS; i++) {
                struct regulator_dev *rdev;
+               int id = regulators[i].id;
 
                config.init_data = pdata->regulators[i].initdata;
                config.of_node = pdata->regulators[i].of_node;
 
-               max77686->opmode[i] = regulators[i].enable_mask >>
-                                               max77686_get_opmode_shift(i);
+               max77686->opmode[id] = regulators[i].enable_mask >>
+                                               max77686_get_opmode_shift(id);
                rdev = devm_regulator_register(&pdev->dev,
                                                &regulators[i], &config);
                if (IS_ERR(rdev)) {