[media] DaVinci-VPFE-Capture: Use kmalloc_array() in vpfe_probe()

* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kmalloc_array".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data type by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

diff --git a/drivers/media/platform/davinci/vpfe_capture.c b/drivers/media/platform/davinci/vpfe_capture.c
index ca22c3493f55ab7bd37747f257bf3adce9ce9650..a9bc35e785a3bf1ed7b86b5fb4e32e750467966d 100644 (file)
--- a/drivers/media/platform/davinci/vpfe_capture.c
+++ b/drivers/media/platform/davinci/vpfe_capture.c
@@ -1938,8 +1938,9 @@ static int vpfe_probe(struct platform_device *pdev)
        video_set_drvdata(&vpfe_dev->video_dev, vpfe_dev);
        i2c_adap = i2c_get_adapter(vpfe_cfg->i2c_adapter_id);
        num_subdevs = vpfe_cfg->num_subdevs;
-       vpfe_dev->sd = kmalloc(sizeof(struct v4l2_subdev *) * num_subdevs,
-                               GFP_KERNEL);
+       vpfe_dev->sd = kmalloc_array(num_subdevs,
+                                    sizeof(*vpfe_dev->sd),
+                                    GFP_KERNEL);
        if (NULL == vpfe_dev->sd) {
                v4l2_err(&vpfe_dev->v4l2_dev,
                        "unable to allocate memory for subdevice pointers\n");