]> git.karo-electronics.de Git - linux-beck.git/commitdiff
ixgbe: drop null test before destroy functions
authorJulia Lawall <julia.lawall@lip6.fr>
Sun, 13 Sep 2015 12:15:13 +0000 (14:15 +0200)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Mon, 23 Nov 2015 19:08:48 +0000 (11:08 -0800)
Remove unneeded NULL test.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@ expression x; @@
-if (x != NULL)
  \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Tested-by: Darin Miller <darin.j.miller@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c

index 631c603fc96649c95995b286577ca7b489d3f58d..5f988703e1b7e464a75b936bf7fb1fbb7f997b2c 100644 (file)
@@ -620,8 +620,7 @@ static void ixgbe_fcoe_dma_pool_free(struct ixgbe_fcoe *fcoe, unsigned int cpu)
        struct ixgbe_fcoe_ddp_pool *ddp_pool;
 
        ddp_pool = per_cpu_ptr(fcoe->ddp_pool, cpu);
-       if (ddp_pool->pool)
-               dma_pool_destroy(ddp_pool->pool);
+       dma_pool_destroy(ddp_pool->pool);
        ddp_pool->pool = NULL;
 }