]> git.karo-electronics.de Git - linux-beck.git/commitdiff
staging: rtl8192u: r8192U_core: fix unnecessary check before kfree code style issue
authorRaphaël Beamonte <raphael.beamonte@gmail.com>
Tue, 18 Aug 2015 16:58:13 +0000 (12:58 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 13 Sep 2015 01:24:34 +0000 (18:24 -0700)
kfree(NULL) is safe and the checks were not required.

Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192u/r8192U_core.c

index cd14c0a680dac6e347f95b9943391dda53fc1629..d0020f1caa26d09148e107e83401cc2c36eb09bf 100644 (file)
@@ -1724,10 +1724,9 @@ static void rtl8192_usb_deleteendpoints(struct net_device *dev)
        }
        kfree(priv->oldaddr);
        priv->oldaddr = NULL;
-       if (priv->pp_rxskb) {
-               kfree(priv->pp_rxskb);
-               priv->pp_rxskb = NULL;
-       }
+
+       kfree(priv->pp_rxskb);
+       priv->pp_rxskb = NULL;
 }
 #else
 void rtl8192_usb_deleteendpoints(struct net_device *dev)
@@ -1752,11 +1751,9 @@ void rtl8192_usb_deleteendpoints(struct net_device *dev)
        priv->rx_urb = NULL;
        kfree(priv->oldaddr);
        priv->oldaddr = NULL;
-       if (priv->pp_rxskb) {
-               kfree(priv->pp_rxskb);
-               priv->pp_rxskb = 0;
 
-       }
+       kfree(priv->pp_rxskb);
+       priv->pp_rxskb = 0;
 
 #endif
 }