ipv6: fix RTPROT_RA markup of RA routes w/nexthops

Userspace implementations of network routing protocols sometimes need to
tell RA-originated IPv6 routes from other kernel routes to make proper
routing decisions. This makes most sense for RA routes with nexthops,
namely, default routes and Route Information routes.

The intended mean of preserving RA route origin in a netlink message is
through indicating RTPROT_RA as protocol code. Function rt6_fill_node()
tried to do that for default routes, but its test condition was taken
wrong. This change is modeled after the original mailing list posting
by Jeff Haran. It fixes the test condition for default route case and
sets the same behaviour for Route Information case (both types use
nexthops). Handling of the 3rd RA route type, Prefix Information, is
left unchanged, as it stands for interface connected routes (without
nexthops).

Signed-off-by: Denis Ovsienko <infrastation@yandex.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 2a4c8d48977f80be1bf97b1c7a9f8da68f25fcf4..412fad809a3bfe9f452d6c86c23f426e718e3ea2 100644 (file)
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -2399,10 +2399,12 @@ static int rt6_fill_node(struct net *net,
        rtm->rtm_protocol = rt->rt6i_protocol;
        if (rt->rt6i_flags & RTF_DYNAMIC)
                rtm->rtm_protocol = RTPROT_REDIRECT;
-       else if (rt->rt6i_flags & RTF_ADDRCONF)
-               rtm->rtm_protocol = RTPROT_KERNEL;
-       else if (rt->rt6i_flags & RTF_DEFAULT)
-               rtm->rtm_protocol = RTPROT_RA;
+       else if (rt->rt6i_flags & RTF_ADDRCONF) {
+               if (rt->rt6i_flags & (RTF_DEFAULT | RTF_ROUTEINFO))
+                       rtm->rtm_protocol = RTPROT_RA;
+               else
+                       rtm->rtm_protocol = RTPROT_KERNEL;
+       }
 
        if (rt->rt6i_flags & RTF_CACHE)
                rtm->rtm_flags |= RTM_F_CLONED;