]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
arm64: fix endianness annotation in acpi_parking_protocol.c
authorLuc Van Oostenryck <luc.vanoostenryck@gmail.com>
Wed, 28 Jun 2017 14:58:07 +0000 (16:58 +0200)
committerWill Deacon <will.deacon@arm.com>
Thu, 29 Jun 2017 10:33:15 +0000 (11:33 +0100)
Here both variables 'cpu_id' and 'entry_point' are read via
read[lq]_relaxed(), from a little-endian annotated pointer
and then used as a native endian value.

This is correct since the read[lq]() family of function
internally do a little-to-native endian conversion.

But in this case, it is wrong to declare these variable as
little-endian since there are native ones.

Fix this by changing the declaration of these variables
as 'u32' or 'u64' instead of '__le32' / '__le64'.

Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
arch/arm64/kernel/acpi_parking_protocol.c

index f35e80aad3789e0af1cb98568179552390c69860..98a20e58758b8a065745ab3716dd81c576aeaff5 100644 (file)
@@ -71,7 +71,7 @@ static int acpi_parking_protocol_cpu_boot(unsigned int cpu)
 {
        struct cpu_mailbox_entry *cpu_entry = &cpu_mailbox_entries[cpu];
        struct parking_protocol_mailbox __iomem *mailbox;
-       __le32 cpu_id;
+       u32 cpu_id;
 
        /*
         * Map mailbox memory with attribute device nGnRE (ie ioremap -
@@ -123,7 +123,7 @@ static void acpi_parking_protocol_cpu_postboot(void)
        int cpu = smp_processor_id();
        struct cpu_mailbox_entry *cpu_entry = &cpu_mailbox_entries[cpu];
        struct parking_protocol_mailbox __iomem *mailbox = cpu_entry->mailbox;
-       __le64 entry_point;
+       u64 entry_point;
 
        entry_point = readq_relaxed(&mailbox->entry_point);
        /*