]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
usb: gadget: rndis: fix Missing req->context assignment
authorLukasz Majewski <l.majewski@samsung.com>
Fri, 10 Feb 2012 08:54:51 +0000 (09:54 +0100)
committerFelipe Balbi <balbi@ti.com>
Tue, 10 Apr 2012 16:11:50 +0000 (19:11 +0300)
It is crucial to assign each req->context value to struct rndis.

The problem happens for multi function gadget (g_multi) when multiple
functions are calling common usb_composite_dev control request.

It might happen that *_setup method from one usb function will
alter some fields of this common request issued by other USB
function.

Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/f_rndis.c

index 7b1cf18df5e3e4cd0706422d3e16d17bc1aad075..52343654f5df5218929e86bf7bdac64bf2577b9e 100644 (file)
@@ -500,6 +500,7 @@ rndis_setup(struct usb_function *f, const struct usb_ctrlrequest *ctrl)
                        if (buf) {
                                memcpy(req->buf, buf, n);
                                req->complete = rndis_response_complete;
+                               req->context = rndis;
                                rndis_free_response(rndis->config, buf);
                                value = n;
                        }