]> git.karo-electronics.de Git - linux-beck.git/commitdiff
i2c: at91: fix code checker warnings
authorCyrille Pitchen <cyrille.pitchen@atmel.com>
Thu, 11 Jun 2015 09:16:32 +0000 (11:16 +0200)
committerWolfram Sang <wsa@the-dreams.de>
Thu, 11 Jun 2015 13:12:53 +0000 (22:12 +0900)
buf_len is a size_t, so unsigned, but was tested with '<= 0'.

Reported-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-at91.c

index 9e54f97a9020717942ed507a4c5fff63511abeb0..1c758cd1e1ba82d4acb56f1684270e5af5437c2e 100644 (file)
@@ -232,7 +232,7 @@ static void at91_twi_dma_cleanup(struct at91_twi_dev *dev)
 
 static void at91_twi_write_next_byte(struct at91_twi_dev *dev)
 {
-       if (dev->buf_len <= 0)
+       if (!dev->buf_len)
                return;
 
        /* 8bit write works with and without FIFO */
@@ -275,7 +275,7 @@ static void at91_twi_write_data_dma(struct at91_twi_dev *dev)
        struct dma_chan *chan_tx = dma->chan_tx;
        unsigned int sg_len = 1;
 
-       if (dev->buf_len <= 0)
+       if (!dev->buf_len)
                return;
 
        dma->direction = DMA_TO_DEVICE;
@@ -347,7 +347,7 @@ error:
 
 static void at91_twi_read_next_byte(struct at91_twi_dev *dev)
 {
-       if (dev->buf_len <= 0)
+       if (!dev->buf_len)
                return;
 
        /* 8bit read works with and without FIFO */