]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
hwmon: (nct6775) Fix size of data->temp array
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 18 Jul 2013 15:01:11 +0000 (18:01 +0300)
committerGuenter Roeck <linux@roeck-us.net>
Mon, 12 Aug 2013 05:10:39 +0000 (22:10 -0700)
Smatch complains that we have a array overflow:

drivers/hwmon/nct6775.c:1456 nct6775_update_device()
error: buffer overflow 'data->temp' 4 <= 4

Guenter Roeck says that the array should have been made larger in
7cbbd6aee6 (Add support for critical low/high temperature limits on
NCT6106).  This patch does that.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/nct6775.c

index f0941d78b98507c4411299a126184cfb002e7a97..25e2c7bea48c97022e1916c242716117f2b3bbf1 100644 (file)
@@ -813,8 +813,8 @@ struct nct6775_data {
        u8 temp_fixed_num;      /* 3 or 6 */
        u8 temp_type[NUM_TEMP_FIXED];
        s8 temp_offset[NUM_TEMP_FIXED];
-       s16 temp[4][NUM_TEMP]; /* 0=temp, 1=temp_over, 2=temp_hyst,
-                               * 3=temp_crit */
+       s16 temp[5][NUM_TEMP]; /* 0=temp, 1=temp_over, 2=temp_hyst,
+                               * 3=temp_crit, 4=temp_lcrit */
        u64 alarms;
        u64 beeps;