]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
spi: spi-topcliff-pch: Fix sparse warnings
authorSachin Kamat <sachin.kamat@linaro.org>
Fri, 31 May 2013 11:47:48 +0000 (17:17 +0530)
committerMark Brown <broonie@linaro.org>
Tue, 4 Jun 2013 17:39:19 +0000 (18:39 +0100)
Fixes the following type of warnings:
drivers/spi/spi-topcliff-pch.c:370:52: warning:
Using plain integer as NULL pointer

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
drivers/spi/spi-topcliff-pch.c

index 35f60bd252dda9e6ce61d474cf317eb301c85ff4..0c8071a618c57c628dc04ff17cc20bcef587450d 100644 (file)
@@ -367,7 +367,7 @@ static irqreturn_t pch_spi_handler(int irq, void *dev_id)
 
        if (reg_spsr_val & SPSR_ORF_BIT) {
                dev_err(&board_dat->pdev->dev, "%s Over run error\n", __func__);
-               if (data->current_msg->complete != 0) {
+               if (data->current_msg->complete) {
                        data->transfer_complete = true;
                        data->current_msg->status = -EIO;
                        data->current_msg->complete(data->current_msg->context);
@@ -659,7 +659,7 @@ static void pch_spi_set_tx(struct pch_spi_data *data, int *bpw)
                list_for_each_entry_safe(pmsg, tmp, data->queue.next, queue) {
                        pmsg->status = -ENOMEM;
 
-                       if (pmsg->complete != 0)
+                       if (pmsg->complete)
                                pmsg->complete(pmsg->context);
 
                        /* delete from queue */
@@ -709,7 +709,7 @@ static void pch_spi_nomore_transfer(struct pch_spi_data *data)
         * [To the spi core..indicating end of transfer] */
        data->current_msg->status = 0;
 
-       if (data->current_msg->complete != 0) {
+       if (data->current_msg->complete) {
                dev_dbg(&data->master->dev,
                        "%s:Invoking callback of SPI core\n", __func__);
                data->current_msg->complete(data->current_msg->context);
@@ -1202,7 +1202,7 @@ static void pch_spi_process_messages(struct work_struct *pwork)
                list_for_each_entry_safe(pmsg, tmp, data->queue.next, queue) {
                        pmsg->status = -EIO;
 
-                       if (pmsg->complete != 0) {
+                       if (pmsg->complete) {
                                spin_unlock(&data->lock);
                                pmsg->complete(pmsg->context);
                                spin_lock(&data->lock);