]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
JFS: use list_move instead of list_del/list_add
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Thu, 6 Sep 2012 07:33:09 +0000 (15:33 +0800)
committerDave Kleikamp <dave.kleikamp@oracle.com>
Fri, 14 Sep 2012 21:08:16 +0000 (16:08 -0500)
Using list_move() instead of list_del() + list_add().

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
fs/jfs/jfs_txnmgr.c

index bb8b661bcc5055aeb63796b1bbcc47c309608019..5fcc02eaa64ca2af23ba4bba6431647fa04deb4e 100644 (file)
@@ -2977,12 +2977,9 @@ int jfs_sync(void *arg)
                                 * put back on the anon_list.
                                 */
 
-                               /* Take off anon_list */
-                               list_del(&jfs_ip->anon_inode_list);
-
-                               /* Put on anon_list2 */
-                               list_add(&jfs_ip->anon_inode_list,
-                                        &TxAnchor.anon_list2);
+                               /* Move from anon_list to anon_list2 */
+                               list_move(&jfs_ip->anon_inode_list,
+                                         &TxAnchor.anon_list2);
 
                                TXN_UNLOCK();
                                iput(ip);