]> git.karo-electronics.de Git - linux-beck.git/commitdiff
xfs: validate acl count
authorChristoph Hellwig <hch@infradead.org>
Sun, 20 Nov 2011 15:35:32 +0000 (15:35 +0000)
committerBen Myers <bpm@sgi.com>
Tue, 29 Nov 2011 04:14:24 +0000 (22:14 -0600)
This prevents in-memory corruption and possible panics if the on-disk
ACL is badly corrupted.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ben Myers <bpm@sgi.com>
fs/xfs/xfs_acl.c

index b6c4b3795c4a000ce27ac3799b5c39ae6c8044e9..76e4266d2e7e4a8fc3bfc609016e4de467b7e5cf 100644 (file)
@@ -42,6 +42,8 @@ xfs_acl_from_disk(struct xfs_acl *aclp)
        int count, i;
 
        count = be32_to_cpu(aclp->acl_cnt);
+       if (count > XFS_ACL_MAX_ENTRIES)
+               return ERR_PTR(-EFSCORRUPTED);
 
        acl = posix_acl_alloc(count, GFP_KERNEL);
        if (!acl)