]> git.karo-electronics.de Git - linux-beck.git/commitdiff
netfilter: ebt_ulog: remove unnecessary spin lock protection
authorGao feng <gaofeng@cn.fujitsu.com>
Mon, 18 Feb 2013 16:59:10 +0000 (16:59 +0000)
committerPablo Neira Ayuso <pablo@netfilter.org>
Fri, 15 Mar 2013 10:56:09 +0000 (11:56 +0100)
No need for spinlock to protect the netlink skb in the
ebt_ulog_fini path. We are sure there is noone using it
at that stage.

Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/bridge/netfilter/ebt_ulog.c

index 3bf43f7bb9d4b3aabe97856c7b999c039a909472..442b0321acb94d34c390c08ddf0b6717aa505d9b 100644 (file)
@@ -319,12 +319,11 @@ static void __exit ebt_ulog_fini(void)
        for (i = 0; i < EBT_ULOG_MAXNLGROUPS; i++) {
                ub = &ulog_buffers[i];
                del_timer(&ub->timer);
-               spin_lock_bh(&ub->lock);
+
                if (ub->skb) {
                        kfree_skb(ub->skb);
                        ub->skb = NULL;
                }
-               spin_unlock_bh(&ub->lock);
        }
        netlink_kernel_release(ebtulognl);
 }