]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
spi: tegra: slink: do not prepare dma transfer with DMA_CTRL_ACK flag
authorLaxman Dewangan <ldewangan@nvidia.com>
Fri, 23 Nov 2012 09:22:39 +0000 (14:52 +0530)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Mon, 1 Apr 2013 13:34:44 +0000 (14:34 +0100)
Spi starts transfer using dma with DMA_CTRL_ACK which is not require
becasue spi driver does not use completed dma_desc after transfer
done and so it does not ack the dma descriptor. Removing the
DMA_CTRL_ACK flag to avoid memory leak in dma driver.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
drivers/spi/spi-tegra20-slink.c

index 17224f0f4d56178c96da18cf3895ac7f8fe4aea4..4e58b53990378112fe1002d420ee254881df2f4f 100644 (file)
@@ -467,7 +467,7 @@ static int tegra_slink_start_tx_dma(struct tegra_slink_data *tspi, int len)
        INIT_COMPLETION(tspi->tx_dma_complete);
        tspi->tx_dma_desc = dmaengine_prep_slave_single(tspi->tx_dma_chan,
                                tspi->tx_dma_phys, len, DMA_MEM_TO_DEV,
-                               DMA_PREP_INTERRUPT |  DMA_CTRL_ACK);
+                               DMA_PREP_INTERRUPT);
        if (!tspi->tx_dma_desc) {
                dev_err(tspi->dev, "Not able to get desc for Tx\n");
                return -EIO;
@@ -486,7 +486,7 @@ static int tegra_slink_start_rx_dma(struct tegra_slink_data *tspi, int len)
        INIT_COMPLETION(tspi->rx_dma_complete);
        tspi->rx_dma_desc = dmaengine_prep_slave_single(tspi->rx_dma_chan,
                                tspi->rx_dma_phys, len, DMA_DEV_TO_MEM,
-                               DMA_PREP_INTERRUPT |  DMA_CTRL_ACK);
+                               DMA_PREP_INTERRUPT);
        if (!tspi->rx_dma_desc) {
                dev_err(tspi->dev, "Not able to get desc for Rx\n");
                return -EIO;