]> git.karo-electronics.de Git - linux-beck.git/commitdiff
staging: lustre: remove unnecessary NULL checks in kernel_comm.c
authorJames Simmons <jsimmons@infradead.org>
Wed, 23 Dec 2015 21:24:46 +0000 (16:24 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Feb 2016 22:20:14 +0000 (14:20 -0800)
Fix checkpatch.pl reports of NULL comparison in kernel_comm.c.

Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/obdclass/kernelcomm.c

index 1081253eefefb558eb78733fdff5b3e44b30160c..c9405e6898621de9508e92451485e0af61e8aa2e 100644 (file)
@@ -59,7 +59,7 @@ int libcfs_kkuc_msg_put(struct file *filp, void *payload)
        mm_segment_t fs;
        int rc = -ENOSYS;
 
-       if (filp == NULL || IS_ERR(filp))
+       if (!filp || IS_ERR(filp))
                return -EBADF;
 
        if (kuch->kuc_magic != KUC_MAGIC) {
@@ -121,12 +121,12 @@ int libcfs_kkuc_group_add(struct file *filp, int uid, unsigned int group,
        }
 
        /* fput in group_rem */
-       if (filp == NULL)
+       if (!filp)
                return -EBADF;
 
        /* freed in group_rem */
        reg = kmalloc(sizeof(*reg) + data_len, 0);
-       if (reg == NULL)
+       if (!reg)
                return -ENOMEM;
 
        reg->kr_fp = filp;
@@ -134,7 +134,7 @@ int libcfs_kkuc_group_add(struct file *filp, int uid, unsigned int group,
        memcpy(reg->kr_data, data, data_len);
 
        down_write(&kg_sem);
-       if (kkuc_groups[group].next == NULL)
+       if (!kkuc_groups[group].next)
                INIT_LIST_HEAD(&kkuc_groups[group]);
        list_add(&reg->kr_chain, &kkuc_groups[group]);
        up_write(&kg_sem);
@@ -149,7 +149,7 @@ int libcfs_kkuc_group_rem(int uid, unsigned int group)
 {
        struct kkuc_reg *reg, *next;
 
-       if (kkuc_groups[group].next == NULL)
+       if (!kkuc_groups[group].next)
                return 0;
 
        if (uid == 0) {
@@ -169,7 +169,7 @@ int libcfs_kkuc_group_rem(int uid, unsigned int group)
                        list_del(&reg->kr_chain);
                        CDEBUG(D_KUC, "Removed uid=%d fp=%p from group %d\n",
                               reg->kr_uid, reg->kr_fp, group);
-                       if (reg->kr_fp != NULL)
+                       if (reg->kr_fp)
                                fput(reg->kr_fp);
                        kfree(reg);
                }
@@ -188,7 +188,7 @@ int libcfs_kkuc_group_put(unsigned int group, void *payload)
 
        down_write(&kg_sem);
        list_for_each_entry(reg, &kkuc_groups[group], kr_chain) {
-               if (reg->kr_fp != NULL) {
+               if (reg->kr_fp) {
                        rc = libcfs_kkuc_msg_put(reg->kr_fp, payload);
                        if (rc == 0)
                                one_success = 1;
@@ -227,12 +227,12 @@ int libcfs_kkuc_group_foreach(unsigned int group, libcfs_kkuc_cb_t cb_func,
        }
 
        /* no link for this group */
-       if (kkuc_groups[group].next == NULL)
+       if (!kkuc_groups[group].next)
                return 0;
 
        down_read(&kg_sem);
        list_for_each_entry(reg, &kkuc_groups[group], kr_chain) {
-               if (reg->kr_fp != NULL)
+               if (reg->kr_fp)
                        rc = cb_func(reg->kr_data, cb_arg);
        }
        up_read(&kg_sem);