]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
staging: wilc1000: change handle_set_ip_address's return type to void
authorChaehyun Lim <chaehyun.lim@gmail.com>
Tue, 19 Apr 2016 00:35:29 +0000 (09:35 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 29 Apr 2016 05:04:55 +0000 (22:04 -0700)
When handle_set_ip_address is called in hostIFthread that is a kernel
thread, it is not checked return type of this function. This patch
changes return type to void and removes braces if statement due to have
a single statement.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wilc1000/host_interface.c

index 70f348ac2143b60850d96a2257b913ab81d68d11..7fcdbb3b4ddf05d5bda4eee22f34eb821007db97 100644 (file)
@@ -349,7 +349,7 @@ static void handle_set_operation_mode(struct wilc_vif *vif,
                netdev_err(vif->ndev, "Failed to set driver handler\n");
 }
 
-static s32 handle_set_ip_address(struct wilc_vif *vif, u8 *ip_addr, u8 idx)
+static void handle_set_ip_address(struct wilc_vif *vif, u8 *ip_addr, u8 idx)
 {
        s32 result = 0;
        struct wid wid;
@@ -370,12 +370,8 @@ static s32 handle_set_ip_address(struct wilc_vif *vif, u8 *ip_addr, u8 idx)
 
        host_int_get_ipaddress(vif, firmware_ip_addr, idx);
 
-       if (result) {
+       if (result)
                netdev_err(vif->ndev, "Failed to set IP address\n");
-               return -EINVAL;
-       }
-
-       return result;
 }
 
 static s32 handle_get_ip_address(struct wilc_vif *vif, u8 idx)