Staging: rtl8188eu: Add new variable to make code compact

Introducing this variable leads to overall more code
compactness and increases readability.

Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8188eu/hal/bb_cfg.c
index 2d3d012d3736a925138a15732b6c696f879d2e02..8eb2b39a0b6737008867f2032cd8371ced743fee 100644 (file)
--- a/drivers/staging/rtl8188eu/hal/bb_cfg.c
+++ b/drivers/staging/rtl8188eu/hal/bb_cfg.c
@@ -600,84 +600,90 @@ static bool config_bb_with_pgheader(struct adapter *adapt)
 static void rtl88e_phy_init_bb_rf_register_definition(struct adapter *Adapter)
 {
        struct hal_data_8188e           *hal_data = GET_HAL_DATA(Adapter);
-
-       hal_data->PHYRegDef[RF_PATH_A].rfintfs = rFPGA0_XAB_RFInterfaceSW;
-       hal_data->PHYRegDef[RF_PATH_B].rfintfs = rFPGA0_XAB_RFInterfaceSW;
-       hal_data->PHYRegDef[RF_PATH_C].rfintfs = rFPGA0_XCD_RFInterfaceSW;
-       hal_data->PHYRegDef[RF_PATH_D].rfintfs = rFPGA0_XCD_RFInterfaceSW;
-
-       hal_data->PHYRegDef[RF_PATH_A].rfintfi = rFPGA0_XAB_RFInterfaceRB;
-       hal_data->PHYRegDef[RF_PATH_B].rfintfi = rFPGA0_XAB_RFInterfaceRB;
-       hal_data->PHYRegDef[RF_PATH_C].rfintfi = rFPGA0_XCD_RFInterfaceRB;
-       hal_data->PHYRegDef[RF_PATH_D].rfintfi = rFPGA0_XCD_RFInterfaceRB;
-
-       hal_data->PHYRegDef[RF_PATH_A].rfintfo = rFPGA0_XA_RFInterfaceOE;
-       hal_data->PHYRegDef[RF_PATH_B].rfintfo = rFPGA0_XB_RFInterfaceOE;
-
-       hal_data->PHYRegDef[RF_PATH_A].rfintfe = rFPGA0_XA_RFInterfaceOE;
-       hal_data->PHYRegDef[RF_PATH_B].rfintfe = rFPGA0_XB_RFInterfaceOE;
-
-       hal_data->PHYRegDef[RF_PATH_A].rf3wireOffset = rFPGA0_XA_LSSIParameter;
-       hal_data->PHYRegDef[RF_PATH_B].rf3wireOffset = rFPGA0_XB_LSSIParameter;
-
-       hal_data->PHYRegDef[RF_PATH_A].rfLSSI_Select = rFPGA0_XAB_RFParameter;
-       hal_data->PHYRegDef[RF_PATH_B].rfLSSI_Select = rFPGA0_XAB_RFParameter;
-       hal_data->PHYRegDef[RF_PATH_C].rfLSSI_Select = rFPGA0_XCD_RFParameter;
-       hal_data->PHYRegDef[RF_PATH_D].rfLSSI_Select = rFPGA0_XCD_RFParameter;
-
-       hal_data->PHYRegDef[RF_PATH_A].rfTxGainStage = rFPGA0_TxGainStage;
-       hal_data->PHYRegDef[RF_PATH_B].rfTxGainStage = rFPGA0_TxGainStage;
-       hal_data->PHYRegDef[RF_PATH_C].rfTxGainStage = rFPGA0_TxGainStage;
-       hal_data->PHYRegDef[RF_PATH_D].rfTxGainStage = rFPGA0_TxGainStage;
-
-       hal_data->PHYRegDef[RF_PATH_A].rfHSSIPara1 = rFPGA0_XA_HSSIParameter1;
-       hal_data->PHYRegDef[RF_PATH_B].rfHSSIPara1 = rFPGA0_XB_HSSIParameter1;
-
-       hal_data->PHYRegDef[RF_PATH_A].rfHSSIPara2 = rFPGA0_XA_HSSIParameter2;
-       hal_data->PHYRegDef[RF_PATH_B].rfHSSIPara2 = rFPGA0_XB_HSSIParameter2;
-
-       hal_data->PHYRegDef[RF_PATH_A].rfSwitchControl = rFPGA0_XAB_SwitchControl;
-       hal_data->PHYRegDef[RF_PATH_B].rfSwitchControl = rFPGA0_XAB_SwitchControl;
-       hal_data->PHYRegDef[RF_PATH_C].rfSwitchControl = rFPGA0_XCD_SwitchControl;
-       hal_data->PHYRegDef[RF_PATH_D].rfSwitchControl = rFPGA0_XCD_SwitchControl;
-
-       hal_data->PHYRegDef[RF_PATH_A].rfAGCControl1 = rOFDM0_XAAGCCore1;
-       hal_data->PHYRegDef[RF_PATH_B].rfAGCControl1 = rOFDM0_XBAGCCore1;
-       hal_data->PHYRegDef[RF_PATH_C].rfAGCControl1 = rOFDM0_XCAGCCore1;
-       hal_data->PHYRegDef[RF_PATH_D].rfAGCControl1 = rOFDM0_XDAGCCore1;
-
-       hal_data->PHYRegDef[RF_PATH_A].rfAGCControl2 = rOFDM0_XAAGCCore2;
-       hal_data->PHYRegDef[RF_PATH_B].rfAGCControl2 = rOFDM0_XBAGCCore2;
-       hal_data->PHYRegDef[RF_PATH_C].rfAGCControl2 = rOFDM0_XCAGCCore2;
-       hal_data->PHYRegDef[RF_PATH_D].rfAGCControl2 = rOFDM0_XDAGCCore2;
-
-       hal_data->PHYRegDef[RF_PATH_A].rfRxIQImbalance = rOFDM0_XARxIQImbalance;
-       hal_data->PHYRegDef[RF_PATH_B].rfRxIQImbalance = rOFDM0_XBRxIQImbalance;
-       hal_data->PHYRegDef[RF_PATH_C].rfRxIQImbalance = rOFDM0_XCRxIQImbalance;
-       hal_data->PHYRegDef[RF_PATH_D].rfRxIQImbalance = rOFDM0_XDRxIQImbalance;
-
-       hal_data->PHYRegDef[RF_PATH_A].rfRxAFE = rOFDM0_XARxAFE;
-       hal_data->PHYRegDef[RF_PATH_B].rfRxAFE = rOFDM0_XBRxAFE;
-       hal_data->PHYRegDef[RF_PATH_C].rfRxAFE = rOFDM0_XCRxAFE;
-       hal_data->PHYRegDef[RF_PATH_D].rfRxAFE = rOFDM0_XDRxAFE;
-
-       hal_data->PHYRegDef[RF_PATH_A].rfTxIQImbalance = rOFDM0_XATxIQImbalance;
-       hal_data->PHYRegDef[RF_PATH_B].rfTxIQImbalance = rOFDM0_XBTxIQImbalance;
-       hal_data->PHYRegDef[RF_PATH_C].rfTxIQImbalance = rOFDM0_XCTxIQImbalance;
-       hal_data->PHYRegDef[RF_PATH_D].rfTxIQImbalance = rOFDM0_XDTxIQImbalance;
-
-       hal_data->PHYRegDef[RF_PATH_A].rfTxAFE = rOFDM0_XATxAFE;
-       hal_data->PHYRegDef[RF_PATH_B].rfTxAFE = rOFDM0_XBTxAFE;
-       hal_data->PHYRegDef[RF_PATH_C].rfTxAFE = rOFDM0_XCTxAFE;
-       hal_data->PHYRegDef[RF_PATH_D].rfTxAFE = rOFDM0_XDTxAFE;
-
-       hal_data->PHYRegDef[RF_PATH_A].rfLSSIReadBack = rFPGA0_XA_LSSIReadBack;
-       hal_data->PHYRegDef[RF_PATH_B].rfLSSIReadBack = rFPGA0_XB_LSSIReadBack;
-       hal_data->PHYRegDef[RF_PATH_C].rfLSSIReadBack = rFPGA0_XC_LSSIReadBack;
-       hal_data->PHYRegDef[RF_PATH_D].rfLSSIReadBack = rFPGA0_XD_LSSIReadBack;
-
-       hal_data->PHYRegDef[RF_PATH_A].rfLSSIReadBackPi = TransceiverA_HSPI_Readback;
-       hal_data->PHYRegDef[RF_PATH_B].rfLSSIReadBackPi = TransceiverB_HSPI_Readback;
+       struct bb_reg_def               *reg[4];
+
+       reg[RF_PATH_A] = &(hal_data->PHYRegDef[RF_PATH_A]);
+       reg[RF_PATH_B] = &(hal_data->PHYRegDef[RF_PATH_B]);
+       reg[RF_PATH_C] = &(hal_data->PHYRegDef[RF_PATH_C]);
+       reg[RF_PATH_D] = &(hal_data->PHYRegDef[RF_PATH_D]);
+
+       reg[RF_PATH_A]->rfintfs = rFPGA0_XAB_RFInterfaceSW;
+       reg[RF_PATH_B]->rfintfs = rFPGA0_XAB_RFInterfaceSW;
+       reg[RF_PATH_C]->rfintfs = rFPGA0_XCD_RFInterfaceSW;
+       reg[RF_PATH_D]->rfintfs = rFPGA0_XCD_RFInterfaceSW;
+
+       reg[RF_PATH_A]->rfintfi = rFPGA0_XAB_RFInterfaceRB;
+       reg[RF_PATH_B]->rfintfi = rFPGA0_XAB_RFInterfaceRB;
+       reg[RF_PATH_C]->rfintfi = rFPGA0_XCD_RFInterfaceRB;
+       reg[RF_PATH_D]->rfintfi = rFPGA0_XCD_RFInterfaceRB;
+
+       reg[RF_PATH_A]->rfintfo = rFPGA0_XA_RFInterfaceOE;
+       reg[RF_PATH_B]->rfintfo = rFPGA0_XB_RFInterfaceOE;
+
+       reg[RF_PATH_A]->rfintfe = rFPGA0_XA_RFInterfaceOE;
+       reg[RF_PATH_B]->rfintfe = rFPGA0_XB_RFInterfaceOE;
+
+       reg[RF_PATH_A]->rf3wireOffset = rFPGA0_XA_LSSIParameter;
+       reg[RF_PATH_B]->rf3wireOffset = rFPGA0_XB_LSSIParameter;
+
+       reg[RF_PATH_A]->rfLSSI_Select = rFPGA0_XAB_RFParameter;
+       reg[RF_PATH_B]->rfLSSI_Select = rFPGA0_XAB_RFParameter;
+       reg[RF_PATH_C]->rfLSSI_Select = rFPGA0_XCD_RFParameter;
+       reg[RF_PATH_D]->rfLSSI_Select = rFPGA0_XCD_RFParameter;
+
+       reg[RF_PATH_A]->rfTxGainStage = rFPGA0_TxGainStage;
+       reg[RF_PATH_B]->rfTxGainStage = rFPGA0_TxGainStage;
+       reg[RF_PATH_C]->rfTxGainStage = rFPGA0_TxGainStage;
+       reg[RF_PATH_D]->rfTxGainStage = rFPGA0_TxGainStage;
+
+       reg[RF_PATH_A]->rfHSSIPara1 = rFPGA0_XA_HSSIParameter1;
+       reg[RF_PATH_B]->rfHSSIPara1 = rFPGA0_XB_HSSIParameter1;
+
+       reg[RF_PATH_A]->rfHSSIPara2 = rFPGA0_XA_HSSIParameter2;
+       reg[RF_PATH_B]->rfHSSIPara2 = rFPGA0_XB_HSSIParameter2;
+
+       reg[RF_PATH_A]->rfSwitchControl = rFPGA0_XAB_SwitchControl;
+       reg[RF_PATH_B]->rfSwitchControl = rFPGA0_XAB_SwitchControl;
+       reg[RF_PATH_C]->rfSwitchControl = rFPGA0_XCD_SwitchControl;
+       reg[RF_PATH_D]->rfSwitchControl = rFPGA0_XCD_SwitchControl;
+
+       reg[RF_PATH_A]->rfAGCControl1 = rOFDM0_XAAGCCore1;
+       reg[RF_PATH_B]->rfAGCControl1 = rOFDM0_XBAGCCore1;
+       reg[RF_PATH_C]->rfAGCControl1 = rOFDM0_XCAGCCore1;
+       reg[RF_PATH_D]->rfAGCControl1 = rOFDM0_XDAGCCore1;
+
+       reg[RF_PATH_A]->rfAGCControl2 = rOFDM0_XAAGCCore2;
+       reg[RF_PATH_B]->rfAGCControl2 = rOFDM0_XBAGCCore2;
+       reg[RF_PATH_C]->rfAGCControl2 = rOFDM0_XCAGCCore2;
+       reg[RF_PATH_D]->rfAGCControl2 = rOFDM0_XDAGCCore2;
+
+       reg[RF_PATH_A]->rfRxIQImbalance = rOFDM0_XARxIQImbalance;
+       reg[RF_PATH_B]->rfRxIQImbalance = rOFDM0_XBRxIQImbalance;
+       reg[RF_PATH_C]->rfRxIQImbalance = rOFDM0_XCRxIQImbalance;
+       reg[RF_PATH_D]->rfRxIQImbalance = rOFDM0_XDRxIQImbalance;
+
+       reg[RF_PATH_A]->rfRxAFE = rOFDM0_XARxAFE;
+       reg[RF_PATH_B]->rfRxAFE = rOFDM0_XBRxAFE;
+       reg[RF_PATH_C]->rfRxAFE = rOFDM0_XCRxAFE;
+       reg[RF_PATH_D]->rfRxAFE = rOFDM0_XDRxAFE;
+
+       reg[RF_PATH_A]->rfTxIQImbalance = rOFDM0_XATxIQImbalance;
+       reg[RF_PATH_B]->rfTxIQImbalance = rOFDM0_XBTxIQImbalance;
+       reg[RF_PATH_C]->rfTxIQImbalance = rOFDM0_XCTxIQImbalance;
+       reg[RF_PATH_D]->rfTxIQImbalance = rOFDM0_XDTxIQImbalance;
+
+       reg[RF_PATH_A]->rfTxAFE = rOFDM0_XATxAFE;
+       reg[RF_PATH_B]->rfTxAFE = rOFDM0_XBTxAFE;
+       reg[RF_PATH_C]->rfTxAFE = rOFDM0_XCTxAFE;
+       reg[RF_PATH_D]->rfTxAFE = rOFDM0_XDTxAFE;
+
+       reg[RF_PATH_A]->rfLSSIReadBack = rFPGA0_XA_LSSIReadBack;
+       reg[RF_PATH_B]->rfLSSIReadBack = rFPGA0_XB_LSSIReadBack;
+       reg[RF_PATH_C]->rfLSSIReadBack = rFPGA0_XC_LSSIReadBack;
+       reg[RF_PATH_D]->rfLSSIReadBack = rFPGA0_XD_LSSIReadBack;
+
+       reg[RF_PATH_A]->rfLSSIReadBackPi = TransceiverA_HSPI_Readback;
+       reg[RF_PATH_B]->rfLSSIReadBackPi = TransceiverB_HSPI_Readback;
 }
 
 static bool config_parafile(struct adapter *adapt)