]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
greybus: ap: clean up svc link management error path
authorJohan Hovold <johan@hovoldconsulting.com>
Thu, 19 Mar 2015 15:46:16 +0000 (16:46 +0100)
committerGreg Kroah-Hartman <greg@kroah.com>
Thu, 19 Mar 2015 16:27:08 +0000 (17:27 +0100)
Return immediately on bundle-init failure when processing SVC link up.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
drivers/staging/greybus/ap.c

index 10f3b4d2443d42bcc04c45a16c3a1cdd325fc957..ea197ac57b524001be1de03c816dd5b6e744d934 100644 (file)
@@ -149,11 +149,13 @@ static void svc_management(struct svc_function_unipro_management *management,
                ret = gb_bundle_init(intf,
                                management->link_up.interface_id,
                                management->link_up.device_id);
-               if (ret)
+               if (ret) {
                        dev_err(hd->parent,
                                "error %d initializing interface %hhu bundle %hhu\n",
                                ret, management->link_up.module_id,
                                management->link_up.interface_id);
+                       return;
+               }
                break;
        default:
                dev_err(hd->parent, "Unhandled UniPro management message\n");