]> git.karo-electronics.de Git - linux-beck.git/commitdiff
net: dsa: mv88e6xxx: Don't modify RGMII delays when not RGMII mode
authorAndrew Lunn <andrew@lunn.ch>
Thu, 10 Nov 2016 14:44:00 +0000 (15:44 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 14 Nov 2016 03:36:35 +0000 (22:36 -0500)
The RGMII modes delays can be set via strapping pings or EEPROM.
Don't change them unless explicitly asked to change them.  The recent
refactoring of setting the MAC configuration changed this behaviours,
in that CPU and DSA ports have any pre-configured RGMII delays
removed. This breaks the Armada 370RD board. Restore the previous
behaviour, in that RGMII delays are only applied/removed when
explicitly asked for via an phy-mode being PHY_INTERFACE_MODE_RGMII*

Fixes: 7340e5ecdbb1 ("net: dsa: mv88e6xxx: setup port's MAC")
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/mv88e6xxx/port.c

index 18eeed083cbda37aaeeaa539254ee192a61c7c94..e4978f6367aac351e8de67a779b72e930779c17e 100644 (file)
@@ -63,9 +63,10 @@ static int mv88e6xxx_port_set_rgmii_delay(struct mv88e6xxx_chip *chip, int port,
                reg |= PORT_PCS_CTRL_RGMII_DELAY_RXCLK |
                        PORT_PCS_CTRL_RGMII_DELAY_TXCLK;
                break;
-       default:
-               /* no delay */
+       case PHY_INTERFACE_MODE_RGMII:
                break;
+       default:
+               return 0;
        }
 
        err = mv88e6xxx_port_write(chip, port, PORT_PCS_CTRL, reg);