]> git.karo-electronics.de Git - linux-beck.git/commitdiff
[media] qt1010: signedness bug in qt1010_init_meas1()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 10 Aug 2012 08:25:03 +0000 (05:25 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sun, 12 Aug 2012 16:21:06 +0000 (13:21 -0300)
qt1010_init_meas2() returns zero on success and negative error codes on
failure so the return type should be int instead of u8.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/common/tuners/qt1010.c

index 2d79b1f5d5ebcebe9a00321ee278239ca64d0a7f..bdc39e11030ea8ddd5d9634c8d41b8ed0f26e983 100644 (file)
@@ -288,7 +288,7 @@ static int qt1010_init_meas1(struct qt1010_priv *priv,
        return qt1010_writereg(priv, 0x1e, 0x00);
 }
 
-static u8 qt1010_init_meas2(struct qt1010_priv *priv,
+static int qt1010_init_meas2(struct qt1010_priv *priv,
                            u8 reg_init_val, u8 *retval)
 {
        u8 i, val;