From: Dan Carpenter Date: Thu, 18 Nov 2010 02:46:25 +0000 (-0500) Subject: ext4: missing unlock in ext4_clear_request_list() X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;ds=sidebyside;h=f4c8cc652d9f70680dd91be60a7a455040d0a282;p=mv-sheeva.git ext4: missing unlock in ext4_clear_request_list() If the the li_request_list was empty then it returned with the lock held. Instead of adding a "goto unlock" I just removed that special case and let it go past the empty list_for_each_safe(). Signed-off-by: Dan Carpenter Signed-off-by: "Theodore Ts'o" --- diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 61182fe6254..ef09d1443d1 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -2799,9 +2799,6 @@ static void ext4_clear_request_list(void) struct ext4_li_request *elr; mutex_lock(&ext4_li_info->li_list_mtx); - if (list_empty(&ext4_li_info->li_request_list)) - return; - list_for_each_safe(pos, n, &ext4_li_info->li_request_list) { elr = list_entry(pos, struct ext4_li_request, lr_request);