From: Hannes Reinecke Date: Fri, 24 Apr 2015 11:18:40 +0000 (+0200) Subject: advansys: use spin_lock_irqsave() in interrupt handler X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=00742c91648cee6f5209b3a18e8b6d21e3b4f0e7;p=linux-beck.git advansys: use spin_lock_irqsave() in interrupt handler We should be using spin_lock_irqsave() when within the interrupt handler. Signed-off-by: Hannes Reinecke Signed-off-by: James Bottomley --- diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c index 15bb8d050457..5ece3178195d 100644 --- a/drivers/scsi/advansys.c +++ b/drivers/scsi/advansys.c @@ -7242,9 +7242,10 @@ static irqreturn_t advansys_interrupt(int irq, void *dev_id) struct Scsi_Host *shost = dev_id; struct asc_board *boardp = shost_priv(shost); irqreturn_t result = IRQ_NONE; + unsigned long flags; ASC_DBG(2, "boardp 0x%p\n", boardp); - spin_lock(shost->host_lock); + spin_lock_irqsave(shost->host_lock, flags); if (ASC_NARROW_BOARD(boardp)) { if (AscIsIntPending(shost->io_port)) { result = IRQ_HANDLED; @@ -7259,7 +7260,7 @@ static irqreturn_t advansys_interrupt(int irq, void *dev_id) ASC_STATS(shost, interrupt); } } - spin_unlock(shost->host_lock); + spin_unlock_irqrestore(shost->host_lock, flags); ASC_DBG(1, "end\n"); return result;