From: David Mosberger-Tang <davidm@egauge.net>
Date: Wed, 28 May 2014 22:09:16 +0000 (-0600)
Subject: usb: host: max3421-hcd: Fix missing unlock in max3421_urb_enqueue()
X-Git-Tag: next-20140530~20^2~9
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=00c5aa178a5ba217a4143f8a5f70630550a87600;p=karo-tx-linux.git

usb: host: max3421-hcd: Fix missing unlock in max3421_urb_enqueue()

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David Mosberger <davidm@egauge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/usb/host/max3421-hcd.c b/drivers/usb/host/max3421-hcd.c
index 28abda14c5e2..714f99faa14a 100644
--- a/drivers/usb/host/max3421-hcd.c
+++ b/drivers/usb/host/max3421-hcd.c
@@ -1545,8 +1545,10 @@ max3421_urb_enqueue(struct usb_hcd *hcd, struct urb *urb, gfp_t mem_flags)
 	if (!max3421_ep) {
 		/* gets freed in max3421_endpoint_disable: */
 		max3421_ep = kzalloc(sizeof(struct max3421_ep), mem_flags);
-		if (!max3421_ep)
-			return -ENOMEM;
+		if (!max3421_ep) {
+			retval = -ENOMEM;
+			goto out;
+		}
 		max3421_ep->ep = urb->ep;
 		max3421_ep->last_active = max3421_hcd->frame_number;
 		urb->ep->hcpriv = max3421_ep;
@@ -1561,6 +1563,7 @@ max3421_urb_enqueue(struct usb_hcd *hcd, struct urb *urb, gfp_t mem_flags)
 		wake_up_process(max3421_hcd->spi_thread);
 	}
 
+out:
 	spin_unlock_irqrestore(&max3421_hcd->lock, flags);
 	return retval;
 }