From: Maik Hampel Date: Tue, 31 Jul 2007 07:37:57 +0000 (-0700) Subject: md: raid10: fix use-after-free of bio X-Git-Tag: v2.6.22.2~46 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=058bfc1cc6700c210024dd9fd391ea8fbbb6c91a;p=karo-tx-linux.git md: raid10: fix use-after-free of bio In case of read errors raid10d tries to print a nice error message, unfortunately using data from an already put bio. Signed-off-by: Maik Hampel Acked-By: NeilBrown Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index fb5d9c6e9de0..e0029ea92dbd 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c @@ -1565,7 +1565,6 @@ static void raid10d(mddev_t *mddev) bio = r10_bio->devs[r10_bio->read_slot].bio; r10_bio->devs[r10_bio->read_slot].bio = mddev->ro ? IO_BLOCKED : NULL; - bio_put(bio); mirror = read_balance(conf, r10_bio); if (mirror == -1) { printk(KERN_ALERT "raid10: %s: unrecoverable I/O" @@ -1573,8 +1572,10 @@ static void raid10d(mddev_t *mddev) bdevname(bio->bi_bdev,b), (unsigned long long)r10_bio->sector); raid_end_bio_io(r10_bio); + bio_put(bio); } else { const int do_sync = bio_sync(r10_bio->master_bio); + bio_put(bio); rdev = conf->mirrors[mirror].rdev; if (printk_ratelimit()) printk(KERN_ERR "raid10: %s: redirecting sector %llu to"