From: Viresh Kumar Date: Thu, 11 Aug 2016 20:27:24 +0000 (-0700) Subject: greybus: firmware: s/should/must X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=0675363ac7ffe27a25bf237ce2bf1e084637a3a0;p=linux-beck.git greybus: firmware: s/should/must Replace 'should' with 'must' to clear the expectation a bit more. Reported-by: Alex Elder Signed-off-by: Viresh Kumar Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/greybus/fw-download.c b/drivers/staging/greybus/fw-download.c index 1c63256b96a6..2d7246887547 100644 --- a/drivers/staging/greybus/fw-download.c +++ b/drivers/staging/greybus/fw-download.c @@ -238,7 +238,7 @@ static int fw_download_find_firmware(struct gb_operation *op) request = op->request->payload; tag = (const char *)request->firmware_tag; - /* firmware_tag should be null-terminated */ + /* firmware_tag must be null-terminated */ if (strnlen(tag, GB_FIRMWARE_TAG_MAX_SIZE) == GB_FIRMWARE_TAG_MAX_SIZE) { dev_err(fw_download->parent, "firmware-tag is not null-terminated\n");