From: Dave Gordon Date: Mon, 13 Jun 2016 16:57:29 +0000 (+0100) Subject: drm/i915/guc: prefer __set/clear_bit() to bitmap_set/clear() X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=072a21cfe0914d0fea771b7d20713248d2d794aa;p=linux-beck.git drm/i915/guc: prefer __set/clear_bit() to bitmap_set/clear() Bitmap operators are overkill when touching only one bit. Signed-off-by: Dave Gordon Reviewed-by: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- diff --git a/drivers/gpu/drm/i915/i915_guc_submission.c b/drivers/gpu/drm/i915/i915_guc_submission.c index 65e67f0f0e91..21daaa5d8f30 100644 --- a/drivers/gpu/drm/i915/i915_guc_submission.c +++ b/drivers/gpu/drm/i915/i915_guc_submission.c @@ -306,7 +306,7 @@ static uint16_t assign_doorbell(struct intel_guc *guc, uint32_t priority) if (id == end) id = GUC_INVALID_DOORBELL_ID; else - bitmap_set(guc->doorbell_bitmap, id, 1); + __set_bit(id, guc->doorbell_bitmap); DRM_DEBUG_DRIVER("assigned %s priority doorbell id 0x%x\n", hi_pri ? "high" : "normal", id); @@ -316,7 +316,7 @@ static uint16_t assign_doorbell(struct intel_guc *guc, uint32_t priority) static void release_doorbell(struct intel_guc *guc, uint16_t id) { - bitmap_clear(guc->doorbell_bitmap, id, 1); + __clear_bit(id, guc->doorbell_bitmap); } /*