From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 18 Oct 2011 06:24:36 +0000 (+0300)
Subject: USB: gadget: midi: fix range check in f_midi_out_open()
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=0889551267e7b6b4d27dc9f726f3d0cb0d976105;p=linux-beck.git

USB: gadget: midi: fix range check in f_midi_out_open()

! has higher precedence than >= and since neither 0 nor 1 are greater
than 8 the condition is always false.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Daniel Mack <zonque@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/usb/gadget/f_midi.c b/drivers/usb/gadget/f_midi.c
index 44858dc074d3..ef1bc7a174ef 100644
--- a/drivers/usb/gadget/f_midi.c
+++ b/drivers/usb/gadget/f_midi.c
@@ -644,7 +644,7 @@ static int f_midi_out_open(struct snd_rawmidi_substream *substream)
 {
 	struct f_midi *midi = substream->rmidi->private_data;
 
-	if (!substream->number >= MAX_PORTS)
+	if (substream->number >= MAX_PORTS)
 		return -EINVAL;
 
 	VDBG(midi, "%s()\n", __func__);