From: Greg Kroah-Hartman Date: Thu, 18 Nov 2010 19:21:04 +0000 (-0800) Subject: Staging: samsung-laptop: fix up my fixup for some sysfs attribute permissions X-Git-Tag: v2.6.36.2~39 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=09af6969af29a9c169c6ebe27db9738f8befa544;p=karo-tx-linux.git Staging: samsung-laptop: fix up my fixup for some sysfs attribute permissions commit 4d7bc388b44e42a1feafa35e50eef4f24d6ca59d upstream. They should be writable by root, not readable. Doh, stupid me with the wrong flags. Reported-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/samsung-laptop/samsung-laptop.c b/drivers/staging/samsung-laptop/samsung-laptop.c index 28700b498273..ac2bf11e1119 100644 --- a/drivers/staging/samsung-laptop/samsung-laptop.c +++ b/drivers/staging/samsung-laptop/samsung-laptop.c @@ -356,7 +356,7 @@ static ssize_t set_silent_state(struct device *dev, } return count; } -static DEVICE_ATTR(silent, S_IRUSR | S_IRUGO, +static DEVICE_ATTR(silent, S_IWUSR | S_IRUGO, get_silent_state, set_silent_state);